-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the IssueProcessor #272
Closed
Labels
enhancement
New feature or request
Comments
6 tasks
C0ZEN
added a commit
to C0ZEN/stale
that referenced
this issue
Jan 23, 2021
3 tasks
hross
pushed a commit
that referenced
this issue
Feb 13, 2021
C0ZEN
added a commit
to C0ZEN/stale
that referenced
this issue
Feb 13, 2021
hross
pushed a commit
that referenced
this issue
Feb 16, 2021
* refactor: move and rename the interfaces/classes closes #272 * docs: update the readme and action to describe the new options for milestones * refactor: split the tests into multiple files * feat(milestones): add new options to exempt all milestones * test: add coverage for the default values * test(milestones): add more coverage (wip) * test(milestones): add more coverage for the multiple exempt milestones * test: reduce duplicated code * test: change some describes * test: add more coverage * test: add more coverage * test: add final coverage * build(tsc): add missing project flag to build with the right tsconfig * test(milestones): use each to reduce the complexity of the tests * chore: fix an eslint issue with prettier on windows the end of line was wrong each time the os process the files * docs: move the contribution section to a dedicated file add more content to help the debug * chore: make sure the rebase is ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I would like to:
src/interfaces
with one file per interfaceCreate a new class to handle a single issue(seems rather hard and basically means rewrote a lot of stuff so I will skip this one)IssueProcessor
toIssuesProcessor
It will reduce the complexity of the
IssueProcessor
class.It will help to avoid creating a bunch of time the same class for the Logger.
The text was updated successfully, but these errors were encountered: