-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to ignore draft PRs #36
Comments
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days |
Bump
…On Fri, Aug 21, 2020, 8:20 AM github-actions[bot] ***@***.***> wrote:
This issue is stale because it has been open 30 days with no activity.
Remove stale label or comment or this will be closed in 5 days
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#36 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB6LA6VJMWH5H2AVPJF2WMLSBZRARANCNFSM4KR4ZKPA>
.
|
Thanks for the bump. I do like this idea and it is probably pretty easy to implement and test. Will take a look... |
I went back to our issues API and it doesn't include draft for pull requests, which means making extra calls for every PR to see if it is draft. So while I love this idea I don't think it's worth making the extra changes to deal with draft PRs right now. |
Closing draft PRs is frustratingly annoying, that coupled with #98, the inability to have spaces in labels, the stale action closed a bunch of PRs that it shouldn't have over a long weekend. |
So basically this action is pretty useless if one uses Draft PRs? I don't worry much about amount of API calls, we usually have not so much PRs, so why not add this as optional? |
@nantiferov one way that already exists is to add a specific label for draft PRs, so you can omit the stale on it. Regarding what the stale action can do, I am in favor of adding a new option which allow people to ignore draft PRs even if we need an extra endpoint call. |
@luketomlinson can you reopen? |
It would be nice to have the option to ignore draft PRs as they are implied to be not ready and can be filtered out.
The text was updated successfully, but these errors were encountered: