Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to ignore draft PRs #36

Closed
Cyberboss opened this issue Feb 8, 2020 · 8 comments · Fixed by #539
Closed

Option to ignore draft PRs #36

Cyberboss opened this issue Feb 8, 2020 · 8 comments · Fixed by #539
Assignees
Labels
enhancement New feature or request

Comments

@Cyberboss
Copy link

It would be nice to have the option to ignore draft PRs as they are implied to be not ready and can be filtered out.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Aug 21, 2020
@Cyberboss
Copy link
Author

Cyberboss commented Aug 21, 2020 via email

@github-actions github-actions bot removed the Stale label Aug 22, 2020
@hross hross added the enhancement New feature or request label Aug 28, 2020
@hross
Copy link
Contributor

hross commented Aug 28, 2020

Thanks for the bump. I do like this idea and it is probably pretty easy to implement and test. Will take a look...

@hross hross self-assigned this Aug 28, 2020
@hross
Copy link
Contributor

hross commented Aug 28, 2020

I went back to our issues API and it doesn't include draft for pull requests, which means making extra calls for every PR to see if it is draft. So while I love this idea I don't think it's worth making the extra changes to deal with draft PRs right now.

@brianeclow
Copy link

Closing draft PRs is frustratingly annoying, that coupled with #98, the inability to have spaces in labels, the stale action closed a bunch of PRs that it shouldn't have over a long weekend.

@nantiferov
Copy link

nantiferov commented Jul 28, 2021

So basically this action is pretty useless if one uses Draft PRs?
This is already quite old GH feature, but official action doesn't support it.
Are there any plans to fix that somehow?

I don't worry much about amount of API calls, we usually have not so much PRs, so why not add this as optional?
Or improve GH API to contain this info without additional calls?

@C0ZEN
Copy link
Contributor

C0ZEN commented Jul 29, 2021

@nantiferov one way that already exists is to add a specific label for draft PRs, so you can omit the stale on it.
It's not convenient though because most repositories are not allowing contributors to add a label.

Regarding what the stale action can do, I am in favor of adding a new option which allow people to ignore draft PRs even if we need an extra endpoint call.
Like the #359 feature request, we can simply warn and discourage such kind of option for consumers that care about API rate limit, but giving this choice is significant IMO.
I am interested in providing such PR BTW.

@C0ZEN
Copy link
Contributor

C0ZEN commented Aug 6, 2021

@luketomlinson can you reopen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants