-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to not close stale issues/prs #16
Conversation
src/main.ts
Outdated
if (wasLastUpdatedBefore(issue, args.daysBeforeClose)) { | ||
operationsLeft -= await closeIssue(client, issue); | ||
} else { | ||
if (args.daysBeforeClose < 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could do:
if (args.daysBeforeClose >= 0 && wasLastUpdatedBefore(issue, args.daysBeforeClose)) {
operationsLeft -= await closeIssue(client, issue);
} else {
continue;
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's cleaner
This is 'approved' but not merged. Is there a way to 'use' unmerged PRs in github workflows? |
@bryanmacfarlane this should probably be merged (or a different solution should be found) |
@eileenmcnaughton - you should be able to use the @dont-close-option ref after the action name. Can you validate the change using that branch ref? |
Is this being merged soon 🙃 ? |
It appears that this is still valid for not closing (adding |
@bretterer if you set |
Fixes #15