Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(statistics): split the stats between issues and PRs #364

Merged
merged 29 commits into from
Apr 27, 2021
Merged

feat(statistics): split the stats between issues and PRs #364

merged 29 commits into from
Apr 27, 2021

Conversation

C0ZEN
Copy link
Contributor

@C0ZEN C0ZEN commented Mar 7, 2021 •
edited
Loading

Changes:

  • Create the logic to display the values as a group (only when two values are at least set)
  • Use toHaveLength in the specs
  • Split the display for all stat which is currently grouping both issues and PRs

Example:

Processed items: 3
├── Processed issues: 1
└── Processed PRs   : 2

Closes #360

C0ZEN and others added 25 commits November 22, 2020 10:55
@C0ZEN
Merge pull request #1 from actions/main
c21e2f2
@C0ZEN
Merge pull request #2 from actions/main
c913fa4
@C0ZEN
Merge pull request #3 from actions/main
9cf9bf2 
feat(stale-and-close): add new options to change the days before clos…
@C0ZEN
Merge pull request #4 from actions/main
f11f623
@C0ZEN
Merge pull request #5 from actions/main
0f1457a 
Remove the stale label when labeled with an exempt one  (actions#268)
@C0ZEN
Merge pull request #6 from actions/main
fef6333
@C0ZEN
Merge pull request #7 from actions/main
e1ba62c
@C0ZEN
Merge pull request #8 from actions/main
abab4a6
@C0ZEN
Merge pull request #9 from actions/main
920683c
@C0ZEN
Merge pull request #10 from actions/main
a98474b
@C0ZEN
Merge pull request #11 from actions/main
915ed27
@C0ZEN
Merge pull request #12 from actions/main
4b097b3 
feat(statistics): display some stats in the logs (actions#337)
@C0ZEN
docs(only-labels): enhance the docs and fix duplicate (actions#341)
5575ade 
* docs(only-labels): remove duplicated option and improve descriptions

a bad rebase happend

* docs(readme): use a multi-line array and remove the optional column

the option column was not helpful since each value is optional
the multi-line array will allow to have a better UI in small devices and basically in GitHub too due to the max-width

* style(readme): break line for the statistics

* docs(readme): add a better description for the ascending option

* docs(action): add missing punctuation
@dependabot @C0ZEN
build(deps-dev): bump @typescript-eslint/eslint-plugin (actions#342)
b806328 
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 4.15.2 to 4.16.1.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.16.1/packages/eslint-plugin)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @C0ZEN
build(deps): bump @octokit/rest from 18.3.0 to 18.3.2 (actions#350)
c6b2c30 
Bumps [@octokit/rest](https://github.com/octokit/rest.js) from 18.3.0 to 18.3.2.
- [Release notes](https://github.com/octokit/rest.js/releases)
- [Commits](octokit/rest.js@v18.3.0...v18.3.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@C0ZEN
Merge pull request #14 from actions/main
5a8ec1e
@C0ZEN @dependabot
test: add more coverage for the stale label behaviour (actions#352) (#15
6c29691 
)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@C0ZEN @dependabot
test: add more coverage for the stale label behaviour (actions#352) (#17
d485d43 
)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@C0ZEN
test(refactor): use toHaveLength
efde10c
@C0ZEN
feat(statistics): split the processed issues and prs
f0f5502
@C0ZEN
feat(statistics): split the new stale issues and prs
5b0af23
@C0ZEN
feat(statistics): split the no longer stale issues and prs
96d047c
@C0ZEN
chore(deps): undo upgrade of dependencies
71853e9
@C0ZEN
feat(statistics): split closed issues and prs
56d2542
@C0ZEN
feat(statistics): use the word "items" when something concern both is…
929bcd9 
…sues and prs
@C0ZEN C0ZEN marked this pull request as ready for review March 9, 2021 19:02
@C0ZEN
Copy link
Contributor Author

C0ZEN commented Mar 9, 2021

@hross this one is ready FYI

luketomlinson
luketomlinson approved these changes Apr 27, 2021
View reviewed changes
Copy link
Collaborator

@luketomlinson luketomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @C0ZEN 🥇

@luketomlinson luketomlinson merged commit 5e20aa8 into actions:main Apr 27, 2021
@C0ZEN C0ZEN deleted the feature/statistics branch April 27, 2021 18:47
@C0ZEN
Copy link
Contributor Author

C0ZEN commented Apr 27, 2021 •
edited
Loading

@luketomlinson any chance you will review more PRs?
I am still eager to provide more contributions once the ones opened are handled FYI.
No hurry though.

@luketomlinson
Copy link
Collaborator

hey @C0ZEN! I am working through these and I hope to get to them soon. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luketomlinson luketomlinson luketomlinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate statistics for issues and for PRs
2 participants
@C0ZEN @luketomlinson