feat(operations): split the operations-per-run option between queries and mutations #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C0ZEN
force-pushed
the
feature/split-queries-and-mutations-limit
branch
2 times, most recently
from
0936a35
to
78dc715
Compare
C0ZEN
force-pushed
the
feature/split-queries-and-mutations-limit
branch
from
78dc715
to
362cdf7
Compare
C0ZEN
force-pushed
the
feature/split-queries-and-mutations-limit
branch
from
362cdf7
to
acd609a
Compare
|
up |
C0ZEN
force-pushed
the
feature/split-queries-and-mutations-limit
branch
from
acd609a
to
8745539
Compare
C0ZEN
commented
Sep 19, 2021
|
up |
C0ZEN
force-pushed
the
feature/split-queries-and-mutations-limit
branch
from
bf103bc
to
c3c7dca
Compare
C0ZEN
commented
Sep 21, 2021
Make sure to log the warning about the overflow of operations when the process fail fast due to a lack of operations as well as when it's finished as expected BREAKING CHANGE: the operations per run option no longer exists and was replaced by the query and mutation ones
C0ZEN
force-pushed
the
feature/split-queries-and-mutations-limit
branch
from
e790815
to
72c9c80
Compare
|
@luketomlinson would be nice if you could review/merge this one and later create the next major release. |
|
@luketomlinson bump and also if you can create a new release it would be nice (maybe go for 4.1) then merge this one if you think it's a good PR then let it idle and create a v5 later. WDYT? |
|
It's sad to see good work go to waste like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
operations-per-runoptionquery-operations-per-run(to read) andmutation-operations-per-run(to alter the issues) options, resolves Feature request: option to limit mutations per run #495Context
For huge projects, it can be scary to process all the issues with this action, especially when it's the first configuration.
The operations-per-run was covering all kind of operations and was helpful, but not enough to process the whole set of issues without changing everything.