Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PowerShell / Pester workflow #661

Closed
wants to merge 6 commits into from

Conversation

potatoqualitee
Copy link

@potatoqualitee potatoqualitee commented Oct 7, 2020

I understand you are not adding new workflows at this time, but I believe PowerShell was overlooked in the original documentation, which is a common problem in our community. Fortunately, PowerShell was not looked over in the runners 🤩

GitHub documentation just went public, I am updating GitHub Action Documentation with a PowerShell example. This workflow will help me create more complete documentation for the community. GitHub has provided runners with PowerShell's testing framework, Pester, built-in and accepting this pull request will help complete the documentation for my proposed PR for adding sample.

In the workflow and properties files:

  • The workflow filename of CI workflows should be the name of the language or platform, in lower case. Special characters should be removed or replaced with words as appropriate (for example, "dotnet" instead of ".NET").

    The workflow filename of publishing workflows should be the name of the language or platform, in lower case, followed by "-publish".

  • Includes a matching ci/properties/*.properties.json file.

  • Use sentence case for the names of workflows and steps, for example "Run tests".

  • The name of CI workflows should only be the name of the language or platform: for example "Go" (not "Go CI" or "Go Build")

  • Include comments in the workflow for any parts that are not obvious or could use clarification.

  • CI workflows should run on push to branches: [ $default-branch ] and pull_request to branches: [ $default-branch ].

  • Packaging workflows should run on release with types: [ created ].

Some general notes:

  • This workflow must only use actions that are produced by GitHub, in the actions organization, or
  • This workflow must only use actions that are produced by the language or ecosystem that the workflow supports. These actions must be published to the GitHub Marketplace. Workflows using these actions must reference the action using the full 40 character hash of the action's commit instead of a tag. Additionally, workflows must include the following comment at the top of the workflow file:
    # This workflow uses actions that are not certified by GitHub.
    # They are provided by a third-party and are governed by
    # separate terms of service, privacy policy, and support
    # documentation.
    
  • This workflow must not send data to any 3rd party service except for the purposes of installing dependencies.
  • This workflow must not use a paid service or product.

@andymckay
Copy link
Contributor

Thank you @potatoqualitee but it still holds that we aren't accepting new community workflows at this time as per #631

@potatoqualitee
Copy link
Author

@andymckay - I am happy to leave this PR open until community workflows are accepted 👍

@github-actions
Copy link

github-actions bot commented Mar 6, 2021

This pull request has become stale and will be closed automatically within a period of time. Sorry about that.

@maciej19861317
Copy link

Racja

@potatoqualitee
Copy link
Author

Do I just recreate this or?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants