Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@actions/github should populate Run Number and Run ID #371

Closed
joshmgross opened this issue Mar 8, 2020 · 1 comment · Fixed by #499
Closed

@actions/github should populate Run Number and Run ID #371

joshmgross opened this issue Mar 8, 2020 · 1 comment · Fixed by #499
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@joshmgross
Copy link
Member

joshmgross commented Mar 8, 2020

Background

The @actions/github package populates a GitHub Context similar to github context available in workflows, see https://github.com/actions/toolkit/blob/master/packages/github/src/context.ts

Issue

This context is missing the Run ID and Run Number, available as GITHUB_RUN_NUMBER and GITHUB_RUN_ID, see https://help.github.com/en/actions/configuring-and-managing-workflows/using-environment-variables#default-environment-variables

We should add these values to the package's context and ensure that the workflow github context matches what's available in this package.

Related: #65

@joshmgross joshmgross added bug Something isn't working good first issue Good for newcomers labels Mar 8, 2020
8398a7 added a commit to 8398a7/toolkit that referenced this issue Jun 14, 2020
8398a7 added a commit to 8398a7/toolkit that referenced this issue Jun 25, 2020
8398a7 added a commit to 8398a7/toolkit that referenced this issue Jun 25, 2020
thboop pushed a commit that referenced this issue Jun 26, 2020
* Add execution state information (#371)

* Type conformance to REST API (#371)

* Changed to get the job name (#371)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants
@joshmgross and others