-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Problem matcher docs #56
Comments
I added one of these to my action and it was working ok, but when I switched it over to run in a Docker container the run started to fail saying the file couldn't be found (I've confirmed it is in the container). Do these not work in Docker containers or is there more to get them working? I used this as my format guide since they seemed to be the same, or close enough that things still worked https://code.visualstudio.com/Docs/editor/tasks#_defining-a-problem-matcher |
@ericsciple is there any reason problem matchers wouldn't work in a docker container? I'm not aware of any, but he would know better |
@damccorm I got it working. I switched from I take that back. The |
We should cover that these will create annotations, and how else users can create annotations using issues on the toolkit docs! |
@thboop as per my comments above I was unable to use problem matchers in a docker based action. Should that be possible or can you only use problem matchers in javascript based actions? |
@xt0rted, problem matchers should work in actions running in docker. I'll take a look shortly and create a ticket if I'm able to reproduce the issue. Otherwise, do you have an example you can link? |
@thboop after I couldn't get it to work I switched to using log commands since it achieved the same thing. |
|
The problem I am having with using Docker for this, that I first need to copy the ProblemMatcher file to the host system: https://github.com/TrueBrain/actions-flake8/blob/initial_work/entrypoint.sh#L5 I am not sure if this is intended, but every other way resulted in errors. It seems |
@TrueBrain I hit the same issue. Your workaround for docker based images worked for me as well. |
Would be helpful to have a schema/explanation of what matchers actually do.
The text was updated successfully, but these errors were encountered: