Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the problem matcher #2

Open
mig4 opened this issue Oct 28, 2019 · 0 comments
Open

Fix the problem matcher #2

mig4 opened this issue Oct 28, 2019 · 0 comments

Comments

@mig4
Copy link
Owner

mig4 commented Oct 28, 2019

AFAICT the purpose of a problem matcher is to capture errors in the output, parse them and provide links to location where the problem originated. Which sounds useful for BATS - we could e.g. link to failing test definition.

However, I'm not sure if BATS provides enough information to do that, it seems you may need at least a file and line number to do that, and bats only provides test name and (in --tap mode) sequence number which I'm not sure if you can correlate back to location.

Also it's not quite clear what the schema of the JSON file for defining problem matchers is, the best thing I could find so far is actions/toolkit#56 which points to this vscode doc.

mig4 added a commit that referenced this issue Oct 28, 2019
It doesn't work, so disable for now, issue opened - #2
mig4 added a commit that referenced this issue Oct 28, 2019
It doesn't work, so disable for now, issue opened - #2
mig4 added a commit that referenced this issue Nov 4, 2019
It doesn't work, so disable for now, issue opened - #2

(cherry picked from commit f791b4e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant