Make sure RequestOptions.keepAlive is applied properly on node20 runtime #1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
It would be great to merge this as it would fix actions using the cache package taking an extra 2 minutes if they don't explicitly |
2 tasks
Closed
5 tasks
luketomlinson
approved these changes
Feb 28, 2024
5 tasks
teatimeguest
added a commit
to teatimeguest/setup-texlive-action
that referenced
this pull request
Mar 9, 2024
teatimeguest
added a commit
to teatimeguest/setup-texlive-action
that referenced
this pull request
Mar 9, 2024
* build(deps): bump @actions/http-client from 2.2.0 to 2.2.1 Bumps [@actions/http-client](https://github.com/actions/toolkit/tree/HEAD/packages/http-client) from 2.2.0 to 2.2.1. - [Changelog](https://github.com/actions/toolkit/blob/main/packages/http-client/RELEASES.md) - [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/http-client) --- updated-dependencies: - dependency-name: "@actions/http-client" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * build: remove patch Merged: actions/toolkit#1572 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: teatimeguest <teatimeguest@gmail.com>
5 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with Node.js v19, http(s)
globalAgentnow useskeep-aliveby default. The currentHttpClientimplementation usesglobalAgentwhenRequestOptions.keepAliveis set tofalse(default), which is fine fornode16runtime but incorrect fornode20.This PR fixes
HttpClientto use a custom agent regardless ofRequestOptions.keepAliveso that the option works correctly on both runtimes.http.globalAgent