Use latest unzip-stream and unzip.Extract
#1724
Conversation
| }) | ||
| ) | ||
| .on('finish', async () => { | ||
| .pipe(unzip.Extract({path: directory})) |
There was a problem hiding this comment.
Glad we don't have to roll our own implementation anymore
There was a problem hiding this comment.
Agreed! Simplifies this a ton.
There was a problem hiding this comment.
Use latest unzip-stream and unzip.Extract
Changes Made:
Updated the unzip-stream dependency.
Reverted to using unzip.Extract() instead of unzip.Parse().
Modifications across package-lock.json, package.json, RELEASES.md, download-artifact.test.ts, and download-artifact.ts.
Detailed Changes
package-lock.json:
Bumped version from 2.1.5 to 2.1.7.
Updated unzip-stream dependency from 0.3.1 to 0.3.4.
package.json:
Bumped version from 2.1.6 to 2.1.7.
RELEASES.md:
Added entry for version 2.1.7 highlighting the unzip-stream update and reversion to unzip.Extract().
download-artifact.test.ts:
Modified test to check for the existence of specific paths to ensure no path traversal.
Updated test case expectations accordingly.
download-artifact.ts:
Removed custom extraction logic and replaced with unzip.Extract().
Recommendations
Testing: Ensure all tests pass after the changes, especially the newly added path traversal checks.
Documentation: Update any relevant documentation to reflect the dependency changes and any new behavior.
Code Review: After confirming tests pass, the changes look aligned with the goals of updating dependencies and simplifying extraction logic.
This updates the
unzip-streamdependency and goes back to usingunzip.Extractoverunzip.Parse.