Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tool-cache: Support for extracting xar compatible archives #207

Merged
merged 15 commits into from
Jul 15, 2020
Merged

tool-cache: Support for extracting xar compatible archives #207

merged 15 commits into from
Jul 15, 2020

Conversation

fwal
Copy link
Contributor

@fwal fwal commented Nov 8, 2019

Adds support for extracting archives compatible with eXtensible ARchiver, most notably *.pkg archives.

@fwal
Copy link
Contributor Author

fwal commented Nov 8, 2019 •
edited
Loading

Seems that I made an assumption that xar would have been installed in the ubuntu image as well 😅. Perhaps this functionality is too narrow to include in this package?

Edit: As there are windows-only extractors already present, I think this should be fine.

@bryanmacfarlane
Copy link
Member

Adding Eric for his thoughts. Caution that there is a binary in this PR.

@bryanmacfarlane
Copy link
Member

I think it's fine to have OS specific variants since some tool installers expose archives in various formats per OS. Curious, was there a specific tool / installer that exposed the tool via a xar that your were interested in writing a setup action for? The reason I ask, is I'm up for taking the functionality as long as there's a benefit trading off the maintenance and cost going forward ...

@bryanmacfarlane bryanmacfarlane added the enhancement New feature or request label Feb 10, 2020
@fwal
Copy link
Contributor Author

fwal commented Feb 10, 2020

Sure! I use this in my setup swift action. The feature in question is used to unpack official swift pkg archives from swift.org. I opted to just copy the required function in there for now.

thboop
thboop requested changes Apr 30, 2020
View reviewed changes
Copy link
Collaborator

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor feedback! Let me know if you don't have time to continue with the PR and I can take it over.

Thank you!

packages/tool-cache/__tests__/tool-cache.test.ts Outdated Show resolved Hide resolved
packages/tool-cache/src/tool-cache.ts Show resolved Hide resolved
packages/tool-cache/src/tool-cache.ts Outdated Show resolved Hide resolved
@thboop thboop requested a review from bryanmacfarlane April 30, 2020 18:53
@bryanmacfarlane
Copy link
Member

... although we'd ❤️ to take the contribution from you @fwal . Do you have time? No rush on our side.

@fwal
Copy link
Contributor Author

fwal commented Apr 30, 2020

Thanks for the feedback! I’ll address everything during next week as it’s holiday here 🇸🇪
Feel free to commit if you can’t wait 🙂

@fwal fwal requested a review from thboop May 3, 2020 19:41
@fwal
Copy link
Contributor Author

fwal commented May 3, 2020

Ready for you, @thboop & @bryanmacfarlane.

@fwal fwal requested a review from thboop May 7, 2020 05:55
thboop
thboop reviewed May 7, 2020
View reviewed changes
.gitignore Show resolved Hide resolved
@snyk-bot snyk-bot mentioned this pull request May 17, 2020
Merged
@fwal fwal requested a review from thboop May 25, 2020 19:56
@thboop thboop self-assigned this Jun 26, 2020
@snyk-bot snyk-bot mentioned this pull request Jun 30, 2020
Open
thboop
thboop approved these changes Jul 14, 2020
View reviewed changes
Copy link
Collaborator

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thboop thboop merged commit 2710592 into actions:master Jul 15, 2020
@thboop
Copy link
Collaborator

thboop commented Jul 15, 2020

Thanks for the contribution! Going to release this in 1.6.0! https://github.com/actions/toolkit/pull/519/files

@fwal fwal deleted the tool-cache-xar branch July 19, 2020 12:46
@fwal fwal mentioned this pull request Jul 22, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Dec 31, 2020
Open
@Jsn2win Jsn2win mentioned this pull request Mar 1, 2021
Open
@lmilbaum lmilbaum mentioned this pull request Mar 10, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Sep 29, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Jul 9, 2022
Open
@MarcelRaschke MarcelRaschke mentioned this pull request Aug 19, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thboop thboop thboop approved these changes

@ericsciple ericsciple Awaiting requested review from ericsciple

@bryanmacfarlane bryanmacfarlane Awaiting requested review from bryanmacfarlane

Assignees

@thboop thboop

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fwal @bryanmacfarlane @thboop