Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions.yml are required in master and branch #20

Closed
JJ opened this issue Sep 6, 2019 · 3 comments
Closed

actions.yml are required in master and branch #20

JJ opened this issue Sep 6, 2019 · 3 comments
Labels
question Further information is requested

Comments

@JJ
Copy link
Contributor

JJ commented Sep 6, 2019

However, there does not seem to be a big problem if they are different. I have changed action.yml in master and not updated it in releases/v1, and there didn't seem to be any major problem. Could it be that the metadata in one and the other can be different? Or maybe that it's just not needed in master and is there just for the show?

@damccorm
Copy link
Contributor

damccorm commented Sep 6, 2019

Its needed in master if you're going to reference uses: action@master, but it isn't needed otherwise. Its still probably best practice to have it though since that's going to be where people first land in your repo and the action.yml defines the metadata for their action

@JJ
Copy link
Contributor Author

JJ commented Sep 6, 2019

Which takes me back to #18. It would be very helpful to know exactly what files are needed in every place.
I see now that the main way of using this would be to work and test in master and then create a release only when there's absolute conviction everything is working... It would be helpful if that was clarified in the documentation... somewhere. (From the get go, it wasn't too clear to me that you could actually test an action in master)

@bryanmacfarlane bryanmacfarlane added the question Further information is requested label Sep 11, 2019
@bryanmacfarlane
Copy link
Member

Closing since Danny answered above.

0x4007 pushed a commit to 0x4007/typescript-action that referenced this issue Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants