[bug] Symlinks are preserved by default #590

daskol · 2024-08-02T22:42:38Z

What happened?

Transition from v4.3.4 to v4.3.5 broke regular building pipelines because actions/upload-artifact does not derefernce symlink anymore by default and upload symlinks as is but not target files.

See "Upload StarPU libraries" job for details.

Oringinal pipeline: https://github.com/nntile/nntile/actions/runs/10142088400/job/28040670213
Broken pipeline: https://github.com/nntile/nntile/actions/runs/10222093470/job/28286024223

What did you expect to happen?

Pipelines are expected to work as before.
Symlinks are dereferenced by default.
This action providesd special option/flag for (de)referencing symlinks (kind of -L/-l in common POSIX utils).

How can we reproduce it?

You can fork repo or create pull request and trigger pipeline on push event.

Anything else we need to know?

No response

What version of the action are you using?

v4.3.5 (no issue with the previous v4.3.4)

What are your runner environments?

linux

Are you on GitHub Enterprise Server? If so, what version?

No response

The text was updated successfully, but these errors were encountered:

Action `action/upload-artifact` with new release no longer dereferences symlinks by default. See actions/upload-artifact#590 for details.

erick-xanadu · 2024-08-05T14:10:16Z

This also affected us. Thanks @daskol for reporting this issue.

cbaeberle · 2024-08-06T11:18:03Z

#589 Seems the same issue.

cipolleschi · 2024-08-06T12:37:09Z

Hi there! Riccardo from Meta, working in the React team and taking care of the React Native build pipeline on GH.
This affected us as well.

daskol · 2024-08-06T13:55:27Z

@robherley Could we revert the changes in the latest release 4.3.5 and create a new release 4.3.6? After that, we can continue working on this issue.

Summary: We had CI on main failing consistently the past couple of days. The problem is that the hermes pipeline is failing to create the iOS XCFramework with the error: > unable to create a Mach-O from the binary at '/Users/runner/work/react-native/react-native/packages/react-native/sdks/hermes/destroot/Library/Frameworks/catalyst/hermes.framework/hermes' The main cause is this upgrade of [upload-artifacts](actions/upload-artifact#590) which breaks symlinks. The solution is to bump the caches and downgrade the `upload-artifact` actions. ## Changelog: [Internal] - Try to fix CI for Hermes Pull Request resolved: #45908 Test Plan: GHA must be green Reviewed By: cortinico Differential Revision: D60828616 Pulled By: cipolleschi fbshipit-source-id: 6976b86dd67e2fd9d806ebaa62f47e39dc44b30d

robherley · 2024-08-06T14:55:30Z

Hey folks, we reverted & released a new version for v4.3.6 to address the regression.

sanjacob · 2024-08-15T11:45:34Z

It would be really nice if this behaviour could be opt-in instead #93 #508.

Edit: after testing it seems that not all symlinks are preserved

robherley · 2024-10-07T18:57:01Z

With v4.4.1, this is fixed:

icfaust · 2024-10-08T07:17:55Z

@robherley It seems that from the original issue steps 1. and 2. have been completed

What did you expect to happen?

Pipelines are expected to work as before.

Symlinks are dereferenced by default.

This action providesd special option/flag for (de)referencing symlinks (kind of -L/-l in common POSIX utils).

Is there any timeline for delivery on step 3?

teo-tsirpanis · 2024-10-08T12:30:55Z

My action builds a Linux library and uploads it to a tarball. The library consists of a libmylibrary.so.1.0 and a symlink libmylibrary.so that points to the former file. Since 4.4.1, that file is not included anymore.

robherley · 2024-10-08T13:26:24Z

@icfaust I don't believe we're going to specifically work on (3) at this time, we were only focused on the regression

robherley · 2024-10-08T13:29:58Z

@teo-tsirpanis Do you have an example or a minimum way to reproduce?

I've added a symlink test to upload-artifact's workflow, as well as toolkit too.

teo-tsirpanis · 2024-10-08T14:17:09Z

@robherley

failing run (artifact)
succeeding run (artifact)

The job in question is Build-Native (ubuntu-latest, dev) and the symlink should be in lib/libtiledb.so in artifact tiledb-native-dev-linux-x86_64.

robherley · 2024-10-08T14:40:09Z

@teo-tsirpanis is it a relative symlink? Could you ls -la the contents before it's uploaded?

Looks like this job is failing to lstat the file: https://github.com/TileDB-Inc/TileDB-CSharp/actions/runs/11227543765/job/31209939977#step:7:20

Warning: ENOENT warning during artifact zip creation. No such file or directory
Error: ENOENT: no such file or directory, lstat 'libtiledb.so.2.27'

The relative link might not be getting resolved 🤔

FreyJo · 2024-10-08T15:08:04Z

We have the same issue as @teo-tsirpanis including the lstat warning.
In our case, the symlink is created via CMakes set_target_properties, which seems to be good practice.
See acados/qpOASES#2

teo-tsirpanis · 2024-10-08T15:39:44Z

It seems to be a relative symlink:

teo@theodore-tiledb:~/code/TileDB$ ls -la build/Default/tiledb/libtiledb.so
lrwxrwxrwx 1 teo teo 17 Sep 19 03:25 build/Default/tiledb/libtiledb.so -> libtiledb.so.2.27

robherley · 2024-10-08T15:57:18Z

Okay, I'll look into a fix. For now feel free to pin to 4.4.0 if you are using relative symlinks.

robherley · 2024-10-08T16:56:19Z

I made a PR for toolkit, I'll have my team take a look:

Properly resolve relative symlinks toolkit#1844

@teo-tsirpanis @FreyJo do y'all want to test with the changes? You can try uploading with my branch version:

uses: actions/upload-artifact@robherley/v4.4.2

teo-tsirpanis · 2024-10-08T18:28:39Z

The workflow succeeded, thanks!

robherley · 2024-10-08T18:36:57Z

v4.4.2 is out, v4 will be updated shortly!

robherley · 2024-10-08T19:18:43Z

And v4 is released with the latest changes 🎉

robherley · 2024-10-09T01:53:19Z

v4 has been temporarily rolled back to v4.4.1 due to:

Unable to upload artifact when using v4.4.2 #630

You can still use v4.4.2 for these symlink changes.

Currently our CI is failing because the upload artifacts does not upload the link files somehow. This would be one fix. Related issue that caused the breaking change: actions/upload-artifact#590

daskol added the bug Something isn't working label Aug 2, 2024

daskol added a commit to nntile/nntile that referenced this issue Aug 3, 2024

Pin down version of action/upload-artifact

c7f8b21

Action `action/upload-artifact` with new release no longer dereferences symlinks by default. See actions/upload-artifact#590 for details.

daskol mentioned this issue Aug 3, 2024

Pin down version of action/upload-artifact nntile/nntile#132

Merged

daskol added a commit to nntile/nntile that referenced this issue Aug 3, 2024

Pin down version of action/upload-artifact (#132)

ccaa40e

Action `action/upload-artifact` with new release no longer dereferences symlinks by default. See actions/upload-artifact#590 for details.

rmoyard mentioned this issue Aug 5, 2024

Update check Catalyst (upload-artifact downgrade && OQC unpin) PennyLaneAI/catalyst#988

Merged

teo-tsirpanis mentioned this issue Aug 5, 2024

Nightly GitHub Actions Build Fail on Sat, August 3rd 2024 TileDB-Inc/TileDB-CSharp#457

Closed

cipolleschi mentioned this issue Aug 6, 2024

[RN][CI] Try to restore caches for Hermes facebook/react-native#45908

Closed

robherley mentioned this issue Aug 6, 2024

Revert to @actions/artifact 2.1.8 #594

Merged

fishilico mentioned this issue Aug 10, 2024

Arch Linux: error: could not open file /var/lib/pacman/sync/selinux.db: Unrecognized archive format archlinuxhardened/selinux#124

Closed

robherley mentioned this issue Sep 20, 2024

Fix regression, auto readlink on symlinks again actions/toolkit#1830

Merged

FreyJo mentioned this issue Oct 8, 2024

Update qpOASES with cmake update acados/acados#1289

Merged

Julow mentioned this issue Oct 8, 2024

CI: Fix test-branch after external action change ocaml-ppx/ocamlformat#2584

Merged

jdblischak mentioned this issue Oct 8, 2024

The centralized nightlies job failed on Wednesday (2024-09-11) TileDB-Inc/centralized-tiledb-nightlies#24

Open

robherley mentioned this issue Oct 8, 2024

Properly resolve relative symlinks actions/toolkit#1844

Merged

robherley mentioned this issue Oct 8, 2024

Bump @actions/artifact to 2.1.11 #627

Merged

robherley mentioned this issue Oct 8, 2024

[bug] Specifying a symbolic link in the file parameter will not upload the target file anymore #589

Closed

robherley mentioned this issue Oct 9, 2024

[bug]: Error: ENOENT: no such file or directory, lstat '...' when trying to upload artifact using wildcard on Linux runners with v4.4.1 #628

Open

iCodeSometime mentioned this issue Oct 9, 2024

Please follow semantic versioning - don’t break my build #631

Open

tkoskela mentioned this issue Oct 9, 2024

Preserve symlinks in CI astro-informatics/purify#359

Merged

markfickett mentioned this issue Oct 9, 2024

download-artifact loses permissions on download actions/download-artifact#14

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[bug] Symlinks are preserved by default #590

[bug] Symlinks are preserved by default #590

daskol commented Aug 2, 2024 •

edited

Loading

erick-xanadu commented Aug 5, 2024

cbaeberle commented Aug 6, 2024

cipolleschi commented Aug 6, 2024

daskol commented Aug 6, 2024

robherley commented Aug 6, 2024

sanjacob commented Aug 15, 2024 •

edited

Loading

robherley commented Oct 7, 2024

icfaust commented Oct 8, 2024

What did you expect to happen?

teo-tsirpanis commented Oct 8, 2024

robherley commented Oct 8, 2024

robherley commented Oct 8, 2024

teo-tsirpanis commented Oct 8, 2024

robherley commented Oct 8, 2024

FreyJo commented Oct 8, 2024 •

edited

Loading

teo-tsirpanis commented Oct 8, 2024

robherley commented Oct 8, 2024

robherley commented Oct 8, 2024

teo-tsirpanis commented Oct 8, 2024

robherley commented Oct 8, 2024

robherley commented Oct 8, 2024

robherley commented Oct 9, 2024

[bug] Symlinks are preserved by default #590

[bug] Symlinks are preserved by default #590

Comments

daskol commented Aug 2, 2024 • edited Loading

What happened?

What did you expect to happen?

How can we reproduce it?

Anything else we need to know?

What version of the action are you using?

What are your runner environments?

Are you on GitHub Enterprise Server? If so, what version?

erick-xanadu commented Aug 5, 2024

cbaeberle commented Aug 6, 2024

cipolleschi commented Aug 6, 2024

daskol commented Aug 6, 2024

robherley commented Aug 6, 2024

sanjacob commented Aug 15, 2024 • edited Loading

robherley commented Oct 7, 2024

icfaust commented Oct 8, 2024

What did you expect to happen?

teo-tsirpanis commented Oct 8, 2024

robherley commented Oct 8, 2024

robherley commented Oct 8, 2024

teo-tsirpanis commented Oct 8, 2024

robherley commented Oct 8, 2024

FreyJo commented Oct 8, 2024 • edited Loading

teo-tsirpanis commented Oct 8, 2024

robherley commented Oct 8, 2024

robherley commented Oct 8, 2024

teo-tsirpanis commented Oct 8, 2024

robherley commented Oct 8, 2024

robherley commented Oct 8, 2024

robherley commented Oct 9, 2024

daskol commented Aug 2, 2024 •

edited

Loading

sanjacob commented Aug 15, 2024 •

edited

Loading

FreyJo commented Oct 8, 2024 •

edited

Loading