Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Upload progress stalled due to chunk timeout change from 5 minutes to 30 seconds. #591

Closed
phillipleblanc opened this issue Aug 6, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@phillipleblanc
Copy link

phillipleblanc commented Aug 6, 2024

What happened?

This PR changed the default chunk upload timeout from 5 minutes to 30 seconds: actions/toolkit#1774

I believe this was done to keep the comment in sync, but it has caused our release pipeline to break consistently: https://github.com/spiceai/spiceai/actions/runs/10257723635/job/28383417254

Run actions/upload-artifact@v4
  
With the provided path, there will be 1 file uploaded
Artifact name is valid!
Root directory input is valid!
Beginning upload of artifact content to blob storage
Error: Upload progress stalled.
Uploaded bytes 8388608
Uploaded bytes [16](https://github.com/spiceai/spiceai/actions/runs/10257723635/job/28383417254#step:22:17)777216
Uploaded bytes 25165824
Uploaded bytes 33554432
Uploaded bytes 41943040
Uploaded bytes 50331648
Uploaded bytes 533586[19](https://github.com/spiceai/spiceai/actions/runs/10257723635/job/28383417254#step:22:20)

What did you expect to happen?

I expected my release pipeline to not have any breaking changes.

How can we reproduce it?

Upload a file from a self-hosted runner that takes longer than 30 seconds to upload. This might be easier to reproduce by hosting a runner in the APAC region and uploading from there (which is where my runner is).

Anything else we need to know?

No response

What version of the action are you using?

v4.3.5

What are your runner environments?

self-hosted

Are you on GitHub Enterprise Server? If so, what version?

No response

@hui-zhou-a
Copy link

Our repo have the same problem since last Friday
https://github.com/ansys/pyedb/actions/runs/10217376097/job/28270992493

@robherley
Copy link
Contributor

Hey folks, we reverted & released a new version for v4.3.6 to address the regression.

SMoraisAnsys added a commit to ansys/pyedb that referenced this issue Aug 6, 2024
Seems like this was a big problem as reverts got performed today in Github action actions/upload-artifact#594 to avoid the problem actions/upload-artifact#591 which affected us in upload-artifact@v4.3.5
@phillipleblanc
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants