Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undo indirect dependency updates from #627 #632

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Undo indirect dependency updates from #627 #632

merged 1 commit into from
Oct 9, 2024
+168,984 −158,943

Conversation

joshmgross
Copy link
Member

@joshmgross joshmgross commented Oct 9, 2024 •
edited
Loading

This is a revert of d50e660 to undo all of the indirect dependency updates from an npm audit fix.

git revert d50e66084c4d29dc5d3326b7a0e67bed9ef4bb1e --no-commit
npm i @actions/artifact@latest    
npm run release

One of these dependencies broke uploading artifacts through a proxy - #630. We're still investigating to figure out which one.

https://github.com/robherley/tmp-artifacts/actions/runs/11259345071/job/31308098535 confirms this fixes the issue.

@joshmgross joshmgross marked this pull request as ready for review October 9, 2024 16:59
@joshmgross joshmgross requested a review from a team as a code owner October 9, 2024 16:59
@joshmgross joshmgross merged commit b4b15b8 into main Oct 9, 2024
9 checks passed
@joshmgross joshmgross deleted the joshmgross/undo-dependency-changes branch October 9, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robherley robherley robherley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshmgross @robherley