Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests #16

Merged
merged 8 commits into from
Aug 19, 2022
Merged

Add tests #16

merged 8 commits into from
Aug 19, 2022

Conversation

yoannchaudet
Copy link
Contributor

@yoannchaudet yoannchaudet commented Aug 18, 2022 •
edited
Loading

Add some tests so we don't regress by accident the action.

@yoannchaudet yoannchaudet marked this pull request as ready for review August 19, 2022 00:44
@yoannchaudet yoannchaudet requested a review from a team as a code owner August 19, 2022 00:44
@yoannchaudet yoannchaudet mentioned this pull request Aug 19, 2022
Merged
@ncfavier
Copy link
Contributor

I think it would be good to also have a test running on a minimal container like alpine:latest, to ensure this works across a wide range of environments.

JamesMGreene
JamesMGreene approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@JamesMGreene JamesMGreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Left a few nits but no blockers. 👍🏻

script/new-artifact.sh Outdated Show resolved Hide resolved
.github/workflows/test-hosted-runners.yml Outdated Show resolved Hide resolved
yoannchaudet and others added 2 commits August 19, 2022 08:55
@yoannchaudet @JamesMGreene
Update .github/workflows/test-hosted-runners.yml
2f32392 
Co-authored-by: James M. Greene <JamesMGreene@github.com>
@yoannchaudet @JamesMGreene
Update script/new-artifact.sh
8ad8227 
Co-authored-by: James M. Greene <JamesMGreene@github.com>
@yoannchaudet yoannchaudet merged commit d3a918b into main Aug 19, 2022
@yoannchaudet yoannchaudet deleted the add-tests branch August 19, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YiMysty YiMysty YiMysty approved these changes

@JamesMGreene JamesMGreene JamesMGreene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yoannchaudet @ncfavier @JamesMGreene @YiMysty