[fix]: limit the max input length of the order desc to 50

actiontech · May 24, 2022 · 90ca7b2 · 90ca7b2
1 parent efc0379
commit 90ca7b2
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 14 deletions.
diff --git a/src/page/Order/Create/__snapshots__/index.test.tsx.snap b/src/page/Order/Create/__snapshots__/index.test.tsx.snap
@@ -114,12 +114,17 @@ exports[`Order/Create should audit sql when user click audit button 1`] = `
                     <div
                       class="ant-form-item-control-input-content"
                     >
-                      <textarea
-                        class="ant-input"
-                        id="describe"
-                        placeholder="common.form.placeholder.input"
-                        style="height: -40px; min-height: -12px; max-height: -40px; resize: none;"
-                      />
+                      <div
+                        class="ant-input-textarea ant-input-textarea-show-count"
+                        data-count="0 / 50"
+                      >
+                        <textarea
+                          class="ant-input"
+                          id="describe"
+                          placeholder="common.form.placeholder.input"
+                          style="height: -40px; min-height: -12px; max-height: -40px; resize: none;"
+                        />
+                      </div>
                     </div>
                   </div>
                 </div>
@@ -2316,12 +2321,17 @@ exports[`Order/Create should render page header 1`] = `
                       <div
                         class="ant-form-item-control-input-content"
                       >
-                        <textarea
-                          class="ant-input"
-                          id="describe"
-                          placeholder="common.form.placeholder.input"
-                          style="height: -40px; min-height: -12px; max-height: -40px; overflow-y: hidden; resize: none; overflow-x: hidden;"
-                        />
+                        <div
+                          class="ant-input-textarea ant-input-textarea-show-count"
+                          data-count="0 / 50"
+                        >
+                          <textarea
+                            class="ant-input"
+                            id="describe"
+                            placeholder="common.form.placeholder.input"
+                            style="height: -40px; min-height: -12px; max-height: -40px; overflow-y: hidden; resize: none; overflow-x: hidden;"
+                          />
+                        </div>
                       </div>
                     </div>
                   </div>

diff --git a/src/page/Order/Create/index.test.tsx b/src/page/Order/Create/index.test.tsx
@@ -22,6 +22,8 @@ import {
   taskSqls,
 } from '../Detail/__testData__';
 
+const orderDescMaxLength = 50;
+
 describe('Order/Create', () => {
   beforeEach(() => {
     jest.useFakeTimers();
@@ -140,7 +142,11 @@ describe('Order/Create', () => {
       target: { value: 'orderName' },
     });
     fireEvent.input(screen.getByLabelText('order.baseInfo.describe'), {
-      target: { value: 'order describe' },
+      target: {
+        value: Array.from({ length: orderDescMaxLength + 1 }, () => 'e').join(
+          ''
+        ),
+      },
     });
 
     fireEvent.mouseDown(screen.getByLabelText('order.sqlInfo.instanceName'));
@@ -197,7 +203,7 @@ describe('Order/Create', () => {
       'ant-btn-loading'
     );
     expect(createOrderSpy).toBeCalledWith({
-      desc: 'order describe',
+      desc: Array.from({ length: orderDescMaxLength }, () => 'e').join(''),
       task_id: String(taskInfo.task_id),
       workflow_subject: 'orderName',
     });

diff --git a/src/page/Order/Create/index.tsx b/src/page/Order/Create/index.tsx
@@ -183,6 +183,8 @@ const CreateOrder = () => {
                   placeholder={t('common.form.placeholder.input', {
                     name: t('order.baseInfo.describe'),
                   })}
+                  maxLength={50}
+                  showCount
                 />
               </Form.Item>
             </Form>