Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix]: Fix tab selection issue when disabled button clicked in work order overview #275

Merged
merged 5 commits into from
Jun 2, 2023

Conversation

LZS911
Copy link
Collaborator

@LZS911 LZS911 commented May 30, 2023

@LZS911 LZS911 requested a review from Rain-1214 May 30, 2023 05:44
@LZS911 LZS911 marked this pull request as draft May 30, 2023 05:46
@github-actions
Copy link

github-actions bot commented May 30, 2023

Coverage report

Total coverage

Status Category Percentage Covered / Total
🟢 Statements 96.55% 6389/6617
🟡 Branches 75.11% 2236/2977
🟢 Functions 96.34% 2026/2103
🟢 Lines 99.5% 29840/29991

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Show files with reduced coverage 🔻

Reduced coverage

Status Filename Statements Branches Functions Lines
🟢 src/page/Order/AuditResult/column.tsx 97.14% 71.43% 96% 100%

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from ea1929a

@LZS911 LZS911 marked this pull request as ready for review May 30, 2023 06:05
<Space>
<div
className={ORDER_OPERATE_COLUMN_CLASS_CONSTANT}
style={{ cursor: 'default' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

给这个元素添加阻止事件冒泡也不可以么?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该是可以的, 因为最开始不只处理了这一个节点, 所以用了这个方法, 我这边改一下.

@Rain-1214 Rain-1214 merged commit dd4cb84 into main Jun 2, 2023
@Rain-1214 Rain-1214 deleted the bugfix/issue-1480 branch June 2, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

被驳回的工单,操作按钮置灰,但实际还可点击
2 participants