Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-ost dry run 失败的提示不明显，建议审核级别使用error #504

Closed
ColdWaterLW opened this issue May 9, 2022 · 1 comment
Closed

gh-ost dry run 失败的提示不明显，建议审核级别使用error #504

ColdWaterLW opened this issue May 9, 2022 · 1 comment
Assignees
@ColdWaterLW
Labels
suggestion verified the issue all pr is verified
Milestone
v1.2205.0

Comments

@ColdWaterLW
Copy link
Collaborator

ColdWaterLW commented May 9, 2022 •
edited
Loading

Describe

开启gh-ost规则，默认的审核level是normal

screenshot-20220509-173823

创建工单，当审核满足条件并触发gh-ost规则检查时，dry-run gh-ost发生错误，但审核结果里显示的信息等级为normal（和规则等级一样），错误容易被忽略
screenshot-20220509-174636

Suggestion

不管规则等级是什么，dry run gh-ost发生错误时，审核结果都显示为error level

Why
@ColdWaterLW ColdWaterLW self-assigned this May 9, 2022
@ColdWaterLW ColdWaterLW mentioned this issue May 10, 2022
Closed
@sjjian sjjian mentioned this issue May 10, 2022
Merged
@sjjian sjjian closed this as completed May 10, 2022
@sjjian sjjian added this to the v1.2205.0 milestone May 10, 2022
@Marcus9530
Copy link
Collaborator

UI Version: main 5bfc004
Server Version: main-ee 9ce7104
验证通过
验证步骤：
1.添加数据源，然后开启审核规则模版，开启改表时超过空间之后使用gh-ost上线
2.创建工单，然后给表新增一个字段，点击审核，触发审核提示，该级别目前为错误级别
image

@Marcus9530 Marcus9530 added the verified the issue all pr is verified label May 27, 2022
LordofAvernus pushed a commit that referenced this issue Nov 6, 2023
@ColdWaterLW
Merge pull request #504 from actiontech/issue_901_avg_execute_time
496b62c 
average execution time statistic implement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ColdWaterLW ColdWaterLW

Labels
suggestion verified the issue all pr is verified
Projects
None yet
Milestone
v1.2205.0
Development

No branches or pull requests
3 participants
@sjjian @ColdWaterLW @Marcus9530