feat: if enable backup sqle will backup for every sql #2760
+181
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winfredLIN
changed the title
ColdWaterLW
requested changes
Nov 18, 2024
| BackupStrategy string `gorm:"type:enum('none','reverse_sql','origin_row','manual');column:backup_strategy;size:20"` // 备份任务支持的备份策略 | ||
| BackupStrategyTip string `gorm:"column:backup_strategy_tip;size:255"` // 推荐备份任务的原因 | ||
| BackupStatus string `gorm:"type:enum('waiting_for_execution','executing','failed','succeed');column:backup_status;size:20"` // 备份任务的执行状态 | ||
| BackupExecInfo string `gorm:"column:backup_exec_info;size:255"` // 备份任务的执行信息，如错误原因 |
sqle/model/task.go
Outdated
| @@ -445,7 +446,7 @@ func (s *Storage) GetTasksByIds(taskIds []uint) (tasks []*Task, foundAllIds bool | |||
| func (s *Storage) GetTaskDetailById(taskId string) (*Task, bool, error) { | |||
| task := &Task{} | |||
| err := s.db.Where("id = ?", taskId). | |||
| Preload("ExecuteSQLs").Preload("RollbackSQLs").First(task).Error | |||
| Preload("ExecuteSQLs").Preload("ExecuteSQLs.BackupTask").First(task).Error | |||
There was a problem hiding this comment.
确认一下preload调整后是否有较大的开销
| e_sql.audit_results, e_sql.audit_level, e_sql.audit_status, e_sql.exec_result, e_sql.exec_status | ||
| var taskSQLsQueryTpl = `SELECT e_sql.id,e_sql.number, e_sql.description, e_sql.content AS exec_sql, e_sql.source_file AS sql_source_file, e_sql.start_line AS sql_start_line, e_sql.sql_type, r_sql.content AS rollback_sql, | ||
| e_sql.audit_results, e_sql.audit_level, e_sql.audit_status, e_sql.exec_result, e_sql.exec_status, | ||
| IFNULL(backup_tasks.backup_strategy, '') AS backup_strategy, |
There was a problem hiding this comment.
SQL优化：在model上定义not null，不用ifnull，减少性能开销
| backupTasks := make([]*model.BackupTask, 0, len(a.task.ExecuteSQLs)) | ||
| for _, sql := range a.task.ExecuteSQLs { | ||
| affectedRows, err := a.plugin.EstimateSQLAffectRows(context.TODO(), sql.Content) | ||
| if err == nil { |
| if a.task.EnableBackup { | ||
| backupTasks := make([]*model.BackupTask, 0, len(a.task.ExecuteSQLs)) | ||
| for _, sql := range a.task.ExecuteSQLs { | ||
| affectedRows, err := a.plugin.EstimateSQLAffectRows(context.TODO(), sql.Content) |
There was a problem hiding this comment.
EstimateSQLAffectRows性能影响极大，需要减少影响范围
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assign in @ColdWaterLW
关联的 issue
https://github.com/actiontech/sqle-ee/issues/1956
测试 https://github.com/actiontech/sqle-ee/issues/1956#issuecomment-2477842021
按序提交，需要在以下PR合并后，再复审。有一部分commit在下面的PR中。
#2756
https://github.com/actiontech/sqle-ee/pull/1978
描述你的变更
确认项（pr提交后操作）
Tip
请在指定复审人之前，确认并完成以下事项，完成后✅
not_compatibleneed_update_doc