Skip to content

active_admin_datetimepicker submitted value attributes bug in commit e522459 #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Cusp2356 opened this issue Jun 20, 2019 · 2 comments · Fixed by #55
Closed

active_admin_datetimepicker submitted value attributes bug in commit e522459 #54

Cusp2356 opened this issue Jun 20, 2019 · 2 comments · Fixed by #55
Assignees
@workgena
Labels
bug

Comments

@Cusp2356
Copy link

Commit e522459 - improve_input_html_options (#53), breaks datetimepicker functionality when an ActiveAdmin form is submitted. Hours and minutes are cut off the submitted value attributes, and the lteq value attribute is overwritten with the submitted gteq value attribute.
@Cusp2356 Cusp2356 mentioned this issue Jun 20, 2019
Merged
Cusp2356 referenced this issue in workgena/active_admin_datetimepicker Jun 20, 2019
@workgena
Add support of Formtastic::String input_html
e522459 
[refs activeadmin-plugins#52]

@mantoszew found the bug with range-input:

- From/To placeholder are missing

This commit aims to fix it.
And also add support of other `input_html` options.

For example:

```ruby
form do |f|
  f.input :created_at, as: :date_time_picker, input_html: { placeholder: 'Text here...' }
end
```
@workgena workgena self-assigned this Jun 21, 2019
@workgena workgena added the bug label Jun 21, 2019
@workgena
Copy link
Contributor

workgena commented Jun 21, 2019 •
edited
Loading

The bug is reproduce-able even on earlier version. Working on a hotfix.

@workgena workgena mentioned this issue Jun 21, 2019
Merged
workgena added a commit to workgena/active_admin_datetimepicker that referenced this issue Jun 21, 2019
@workgena
Fix filter input when type if datetime
ed0ac9f 
[fixes activeadmin-plugins#54]

Add test after form submission
@workgena
Copy link
Contributor

Version 0.7.2 released to the RubyGems. It should fix the issue.

Please notice that H:M works correctly only if column in database is t.datetime or t.timestamp(s)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@workgena workgena

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix datetime H:M truncation workgena/active_admin_datetimepicker
2 participants
@workgena @Cusp2356