Skip to content

Fix compatibility with ActiveAdmin 2.6 #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2020
Merged

Fix compatibility with ActiveAdmin 2.6 #67

merged 1 commit into from
Feb 10, 2020

Conversation

workgena
Copy link
Contributor

@workgena workgena commented Feb 7, 2020 •
edited
Loading

This PR fixes #65, which is actually a broken compatibility with ActiveAdmin 2.6

  • Remove all ActiveAdmin less then 1.4 (all of them were identical, according to date_range_input.rb
  • Fix compatibility with ActieAdmin 2.6+ and remain compatible with older versions
  • Add new specs to cover the fix

@workgena workgena changed the title Update Travis CI with ActiveAdmin 2.6.0 Fix compatibility with ActiveAdmin 2.6.0 Feb 7, 2020
@workgena workgena changed the title Fix compatibility with ActiveAdmin 2.6.0 Fix compatibility with ActiveAdmin 2.6 Feb 7, 2020
@coveralls
Copy link

coveralls commented Feb 7, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.7%) to 96.169% when pulling 6561d7c on workgena:aa_2.6 into fa1d2ad on activeadmin-plugins:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.3%) to 94.158% when pulling 22f9793 on workgena:aa_2.6 into fa1d2ad on activeadmin-plugins:master.

@workgena workgena marked this pull request as ready for review February 7, 2020 15:03
@workgena workgena requested a review from Fivell February 7, 2020 15:03
@workgena workgena merged commit e900b93 into activeadmin-plugins:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fivell Fivell Fivell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"To" being set to "From" after submit.
3 participants
@workgena @coveralls @Fivell