Skip to content

Add NPM module support #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2022

Conversation

Skumring
Copy link
Contributor

@Skumring Skumring commented Apr 8, 2022

This PR adds support to use this repo as an NPM/Yarn package so we can use it with Webpacker or any other assets bundler.
I implemented this so it uses the same source files as the Rails gem so any change in the JS and CSS is available in both cases. I didn't change the Rails gem-related code this same repo can be used in both ways.

After pack&publish NPM module has minimum files and should look like:
NPM

@Skumring Skumring force-pushed the add-npm-module-support branch from 8aeca4e to 8225994 Compare April 15, 2022 06:13
@Skumring Skumring marked this pull request as ready for review April 15, 2022 06:20
@gigorok gigorok merged commit 87ffc00 into activeadmin-plugins:master Apr 15, 2022
@Skumring Skumring deleted the add-npm-module-support branch April 15, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants