Fix ActionView deprecation regarding single arity template handlers #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ActionView recently changed the template handler implementation to pass in the source directly. A deprecation warning is shown for handlers that don't accept a direct source.
deivid-rodriguez
approved these changes
Mar 11, 2019
|
Thanks @aramvisser! ❤️ |
varyonic
pushed a commit
to varyonic/arbo
that referenced
this pull request
Feb 8, 2022
…ctiveadmin#110) ActionView recently changed the template handler implementation to pass in the source directly. A deprecation warning is shown for handlers that don't accept a direct source.
varyonic
pushed a commit
to varyonic/arbo
that referenced
this pull request
Feb 8, 2022
…ctiveadmin#110) ActionView recently changed the template handler implementation to pass in the source directly. A deprecation warning is shown for handlers that don't accept a direct source.
varyonic
pushed a commit
to varyonic/arbo
that referenced
this pull request
Feb 8, 2022
…ctiveadmin#110) ActionView recently changed the template handler implementation to pass in the source directly. A deprecation warning is shown for handlers that don't accept a direct source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using rails6.0.0.beta2, ActionView gives a deprecation warning regarding single arity template handlers. Template handlers now receive the source directly as a second parameter,
rails/rails@28f88e0
This commit fixes the deprecation warning, while still allowing old version of ActionView to call the template handler with a single parameter.