Revert the fix to link_to helper with a block #121
Conversation
It has caused several regressions. In order to unblock shipping other improvements, I propose to revert the fix until we find a non-regressing one.
|
If anybody has a good fix for this that doesn't regress, of course that's better than this PR. I spent a bit of time yesterday and my conclusion was... "it's not easy". Also, if somebody can write a spec to ensure that we don't regress again, that's also great! I also tried that yesterday but couldn't get something to fail in arbre's specs. My conclusion was that it's probably easier to test this in the activeadmin repo. |
|
That’s a good suggestion for testing it in the AA repo instead or maybe in both. I’m not familiar with this change so I won’t be of help, sorry. We can open or reopen a related issue and let others know this was attempted and that we are looking for contributions to work out the issues. But at least that we are open to a resolution. |
It has caused several regressions. In order to unblock shipping other improvements, I propose to revert the fix until we find a non-regressing one.
Closes #119.
Closes #120.
Reopens #46.