Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'main' to HTML5 elements #270

Merged
merged 1 commit into from
Jun 17, 2022
Merged

Conversation

mynnx
Copy link
Contributor

@mynnx mynnx commented Jan 30, 2021

From MDN:

The HTML <main> element represents the dominant content of the of a document. The main content area consists of content that is directly related to or expands upon the central topic of a document, or the central functionality of an application.

It's been in the spec since 2012 and I'd love to improve the accessibility of ActiveAdmin by including it!

@mynnx
Copy link
Contributor Author

mynnx commented Mar 3, 2021

Can any maintainer please take a look at this change?

@mynnx
Copy link
Contributor Author

mynnx commented Sep 2, 2021

Is this project still maintained? @deivid-rodriguez @javierjulio

@karloscarweber
Copy link

@mynnx I don't think this project is still actively maintained but it's pretty darn close to being maintained. Try pinging the maintainers again.

@mynnx
Copy link
Contributor Author

mynnx commented Jun 16, 2022

At @karloscarweber 's suggestion,

Is this project still maintained? @deivid-rodriguez @javierjulio

Copy link
Member

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not getting to this earlier, it looks good to me! 👍

@javierjulio javierjulio merged commit d4ea951 into activeadmin:master Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants