Fix spec warnings #650
Merged
Fix spec warnings #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix `warning: assigned but unused variable - comp` warning
It does not have effect there and outputs a warning when running tests with `RUBYOPTS='-w' rake` ``` warning: 'frozen_string_literal' is ignored after any tokens ``` Behavior tested in `empty.arb` template ``` # frozen_string_literal: true hello = 'hello' hello.concat ' world' ``` Expected: fail Actual: pass Close #649
tagliala
force-pushed
the
chore/649-fix-warnings
branch
from
eddb9ce to
2bd6d87
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #650 +/- ##
=======================================
Coverage 94.33% 94.33%
=======================================
Files 17 17
Lines 459 459
=======================================
Hits 433 433
Misses 26 26 ☔ View full report in Codecov by Sentry. |
Parity with ActiveAdmin to prevent introduction of new warnings Manually fix a `Lint/UselessAssignment` warning Ref: activeadmin/activeadmin#8597
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix unassigned variable warning
Fix
warning: assigned but unused variable - compwarningRemove frozen string literals from arb templates
It does not have effect there and outputs a warning when running tests
with
RUBYOPTS='-w' rakeBehavior tested in
empty.arbtemplateExpected: fail
Actual: pass
Close #649