Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing HTML5 elements #655

Merged
merged 2 commits into from
Feb 2, 2025
Merged

Conversation

tagliala
Copy link
Contributor

@tagliala tagliala commented Jan 31, 2025

Source: https://developer.mozilla.org/en-US/docs/Web/HTML

New, non experimental, non deprecated elements:

- <bdi>
- <data>
- <dialog>
- <picture>
- <rp>
- <rt>
- <ruby>
- <search>
- <slot>
- <template>
- <u>

Close #654


2 commits for an easier review

  • First commit, is a stylistic change (one element per line)
  • Second commit contains new elements: d78ebaa

This commit reformats the AUTO_BUILD_ELEMENTS list within the HTML
module. Each element now occupies a separate line.

Previously, the list was densely packed, making it harder to read and
maintain. This change:

- Improves readability by providing visual separation between elements.
- Facilitates easier sorting, both manually and potentially with future
  tooling.
- Reduces the scope of diffs when the list is modified. Future changes
  will only affect the relevant lines, not the entire list.
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.33%. Comparing base (0405ce9) to head (be063a9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #655   +/-   ##
=======================================
  Coverage   94.33%   94.33%           
=======================================
  Files          17       17           
  Lines         459      459           
=======================================
  Hits          433      433           
  Misses         26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tagliala tagliala changed the title Feature/654 add missing html5 elements Add missing HTML5 elements Jan 31, 2025
Source: https://developer.mozilla.org/en-US/docs/Web/HTML

New, non experimental, non deprecated elements:
- <bdi>
- <data>
- <dialog>
- <picture>
- <rp>
- <rt>
- <ruby>
- <search>
- <slot>
- <template>
- <u>

Close #654
@tagliala tagliala force-pushed the feature/654-add-missing-html5-elements branch from d78ebaa to be063a9 Compare January 31, 2025 09:47
@tagliala tagliala requested a review from javierjulio February 1, 2025 16:59
Copy link
Member

@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tagliala tagliala merged commit 386af3b into master Feb 2, 2025
21 checks passed
@tagliala tagliala deleted the feature/654-add-missing-html5-elements branch February 2, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing tags [:bdi, :rp, :rt, :ruby, :u, :dialog]
2 participants