Support setting parent_controller

[jaynetics]

fixes #618

for the interface, i mirrored Devise::parent_controller=.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.92%. Comparing base (cafbfbf) to head (a156fb0).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #903   +/-   ##
=======================================
  Coverage   98.91%   98.92%           
=======================================
  Files          14       14           
  Lines         555      556    +1     
=======================================
+ Hits          549      550    +1     
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jaynetics]

rebased to bring up-to-date with master.

@tagliala could we get this one merged?

[tagliala]

can I ask if this is the same as

https://github.com/heartcombo/devise/blob/a259ff3c28912a27329727f4a3c2623d3f5cb6f2/lib/devise.rb#L244-L245

?

Ref: https://github.com/rails/rails/blob/56fbc632a378acc40d99f5b4be321f80a5d8b8c4/activesupport/lib/active_support/core_ext/module/attribute_accessors.rb#L208-L212

[jaynetics]

@tagliala i'd say its equivalent – the block is evaluated and the class variable is set immediately:

https://github.com/rails/rails/blob/56fbc632a378acc40d99f5b4be321f80a5d8b8c4/activesupport/lib/active_support/core_ext/module/attribute_accessors.rb#L69-L70

i think the devise code is just like that because when José Valim wrote these lines 13 years ago, mattr_accessor did not yet support passing a default value:

https://github.com/rails/rails/blob/bf526c2dbeb73bf11553004e43889a804b72866d/activesupport/lib/active_support/core_ext/module/attribute_accessors.rb#L60

[tagliala]

I think this may be an interesting change, I may need this for a use case where I want to alias current_admin_user to current_user and add some other admin-specific actions

[jaynetics]

My use case is the same as in the original issue: running rails in API mode.

I've been using this fork and the setting parent_controller = 'ActionController::Base' in production for 8 months now without issues.