Add frozen string literal magic comment (potential breaking change) #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tagliala
force-pushed
the
chore/frozen-string-literals
branch
4 times, most recently
from
bfc7227
to
7fccb80
Compare
This cop was disabled probably by mistake, since it is present in both Arbre and Active Admin gems The only production code affected is: - app/controllers/inherited_resources/base.rb - lib/inherited_resources/version.rb Change to `version.rb` is safe. After inspecting the source code of `InheritedResources` module, the change seems safe, but it can represent a breaking change in third-party application. Since we are bumping the major version number, it would be fine to break if documented. Fixed with `rubocop -A` Also adds `Style/Encoding` cop for parity with Arbre
tagliala
force-pushed
the
chore/frozen-string-literals
branch
from
7fccb80
to
cb1bc19
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #933 +/- ##
=======================================
Coverage 98.92% 98.92%
=======================================
Files 14 14
Lines 557 557
=======================================
Hits 551 551
Misses 6 6 ☔ View full report in Codecov by Sentry. |
tagliala
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cop was disabled probably by mistake, since it is present in both
Arbre and Active Admin gems
The only production code affected is:
Change to
version.rbis safe.After inspecting the source code of
InheritedResourcesmodule, thechange seems safe, but it can represent a breaking change in third-party application.
Since we are bumping the major version number, it would be fine to break
if documented.
Fixed with
rubocop -AAlso adds
Style/Encodingcop for parity with Arbre