Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set TMPDIR in espy script if TMPDIR is mounted as noexec #43

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Set TMPDIR in espy script if TMPDIR is mounted as noexec #43

merged 1 commit into from
Jul 20, 2021

Conversation

Zalgo2462
Copy link
Contributor

Closes #42

@Zalgo2462
Copy link
Contributor Author

Turns out this should already be called by check_docker-compose.sh. ...

@Zalgo2462 Zalgo2462 closed this Jul 20, 2021
@Zalgo2462
Copy link
Contributor Author

Turns out that check_docker-compose.sh calls require_executable_tmp_dir but the wrapper script does not source check_docker-compose, so TMPDIR is only set in the child script.

@Zalgo2462 Zalgo2462 reopened this Jul 20, 2021
@Zalgo2462
Copy link
Contributor Author

Tested on CentOS 7 with sudo mount -t tmpfs -o defaults,size=512M,noexec tmpfs /tmp/

fullmetalcache
fullmetalcache approved these changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@fullmetalcache fullmetalcache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working

@fullmetalcache fullmetalcache merged commit 569a6be into master Jul 20, 2021
@fullmetalcache fullmetalcache deleted the 42-tmp-noexec branch July 20, 2021 17:21
@fullmetalcache fullmetalcache changed the title Set TMPDIR in beaker script if TMPDIR is mounted as noexec Set TMPDIR in espy script if TMPDIR is mounted as noexec Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fullmetalcache fullmetalcache fullmetalcache approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Installation/ Espy script fails on systems with /tmp mounted as noexec
2 participants
@Zalgo2462 @fullmetalcache