Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centos 8 installation fixes #30

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Centos 8 installation fixes #30

merged 2 commits into from
Feb 10, 2023

Conversation

J0RDANI
Copy link
Contributor

@J0RDANI J0RDANI commented Feb 2, 2023 •
edited
Loading

Allows systems using RedHat Release 8 to install and removes the podman and buildah packages to avoid conflicts with Docker. To test this PR, run install_docker.sh and acm_lib.sh.

image
image

@Zalgo2462 Zalgo2462 self-requested a review February 5, 2023 01:18
Zalgo2462
Zalgo2462 approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@Zalgo2462 Zalgo2462 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this patch on the following OS's:

  • CentOS 8 Stream
  • Alma Linux 8
  • Rocky Linux 8

The patch worked well on all three.

@Zalgo2462 Zalgo2462 merged commit cdeedf3 into master Feb 10, 2023
@Zalgo2462 Zalgo2462 deleted the centos8 branch February 10, 2023 02:32
@caffeinatedpixel caffeinatedpixel mentioned this pull request Feb 14, 2023
Merged
@Zalgo2462 Zalgo2462 mentioned this pull request Feb 14, 2023
Closed
@caffeinatedpixel caffeinatedpixel mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zalgo2462 Zalgo2462 Zalgo2462 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@J0RDANI @Zalgo2462