-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added more file formats for compression #1597
Conversation
@farizrahman4u can you review the changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need unit tests.
@farizrahman4u Can you review the changes I have made? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the files not required from the PR, address ALL comments and lint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test images are in the wrong location, they should be in hub/tests/dumm_data/images, and their paths should be returned from compressed_image_paths.
Co-authored-by: Fariz Rahman <farizrahman4u@gmail.com>
Co-authored-by: Fariz Rahman <farizrahman4u@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the Pillow and hub-test-resources folders from the PR.
@farizrahman4u Can you review the changes? |
@farizrahman4u any update? |
@aadityasinha-dotcom tests are still failing. This needs to be fixed, otherwise we cannot merge. Thank you! |
Yes I will look into it. |
Hey @FayazRahman , why these tests are failing I tried to run test_tensorflow.py in my system but it was giving no errors. |
@aadityasinha-dotcom Can you pull main and try again? |
@FayazRahman I have pulled the main branch. |
Codecov ReportBase: 91.98% // Head: 92.21% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1597 +/- ##
==========================================
+ Coverage 91.98% 92.21% +0.22%
==========================================
Files 245 246 +1
Lines 25689 26104 +415
==========================================
+ Hits 23631 24072 +441
+ Misses 2058 2032 -26
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Yaaaaay, @aadityasinha-dotcom - congrats on the contribution! Can you please hit me up in the community slack to arrange for some swag? :) |
🚀 🚀 Pull Request
Checklist:
coverage-rate
upChanges