Kushki: Enable 3ds2 #4832
Closed
Kushki: Enable 3ds2 #4832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jherreraa
force-pushed
the
Kushki_enable_3ds2_feature
branch
from
55af594
to
4405d1e
Compare
jherreraa
requested review from
Heavyblade,
sinourain,
edgarv09,
javierpedrozaing and
gasb150
Heavyblade
reviewed
Jul 19, 2023
There was a problem hiding this comment.
Looks pretty much OK @jherreraa leaved some comments and remember to add jira Id to the PR description and commit message.
jherreraa
force-pushed
the
Kushki_enable_3ds2_feature
branch
from
4405d1e
to
a2ec3ae
Compare
jherreraa
force-pushed
the
Kushki_enable_3ds2_feature
branch
from
a2ec3ae
to
0c8b098
Compare
curiousepic
reviewed
Jul 24, 2023
Summary: Enable 3ds version 2 on the gateway above SER-625 Unit Test Finished in 0.019977 seconds. ------------------------------------------------------------------------------------------------------ 17 tests, 109 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed ------------------------------------------------------------------------------------------------------ Remote Test Finished in 82.28609 seconds. ------------------------------------------------------------------------------------------------------ 23 tests, 68 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed ------------------------------------------------------------------------------------------------------
jherreraa
force-pushed
the
Kushki_enable_3ds2_feature
branch
from
0c8b098
to
b575cc4
Compare
|
Merged in d9c926a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Enable 3ds version 2 on the gateway above
SER-625
Remote Tests
Finished in 77.484256 seconds.
22 tests, 67 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Unit Tests
Finished in 0.019977 seconds.
17 tests, 109 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
RuboCop:
760 files inspected, no offenses detected