Ebanx: Add support for Stored Credentials #5243
Merged
+264
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinourain
approved these changes
Aug 30, 2024
| @@ -50,6 +50,7 @@ def purchase(money, payment, options = {}) | |||
| add_address(post, options) | |||
| add_customer_responsible_person(post, payment, options) | |||
| add_additional_data(post, options) | |||
| add_stored_credentials(post, options) | |||
There was a problem hiding this comment.
The purchase and authorize methods are almost the same, I think it would be good to take advantage of the opportunity we have now to abstract the entire post population into a new method.
Remote 39 tests, 95 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 94.8718% passed
almalee24
force-pushed
the
ebanx_stored_creds
branch
from
2a9769a
to
591523c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remote
39 tests, 95 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 94.8718% passed