Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuvei: Add partial approval feature #5250

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

javierpedrozaing
Copy link
Collaborator

Description

SER-1356

This commit enable partial approval for payment sending a GSF flag

Unit test

Finished in 0.010615 seconds.

1 tests, 3 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

94.21 tests/s, 282.62 assertions/s

Remote test

Finished in 37.737084 seconds.

18 tests, 50 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

0.48 tests/s, 1.32 assertions/s

Rubocop

801 files inspected, no offenses detected

@javierpedrozaing javierpedrozaing force-pushed the SER-1356_nuvei_partial_approval branch 2 times, most recently from 9f108f1 to 80f0f1d Compare September 18, 2024 20:59
@javierpedrozaing javierpedrozaing marked this pull request as ready for review September 24, 2024 13:57
Copy link
Collaborator

@Heavyblade Heavyblade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks 👍 , @javierpedrozaing

Copy link
Contributor

@naashton naashton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@naashton naashton force-pushed the SER-1356_nuvei_partial_approval branch from 78f85d2 to 01dc29f Compare October 18, 2024 15:42
Description
-------------------------
[SER-1356](https://spreedly.atlassian.net/browse/SER-1356)

This commit enable partial approval for payment sending a GSF flag

Unit test
-------------------------
Finished in 0.010615 seconds.

1 tests, 3 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

94.21 tests/s, 282.62 assertions/s

Remote test
-------------------------
Finished in 37.737084 seconds.

18 tests, 50 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

0.48 tests/s, 1.32 assertions/s

Rubocop
-------------------------
801 files inspected, no offenses detected
@naashton naashton force-pushed the SER-1356_nuvei_partial_approval branch from 01dc29f to 223bf04 Compare October 18, 2024 15:48
@naashton naashton merged commit 82a6fa1 into master Oct 18, 2024
5 checks passed
@naashton naashton deleted the SER-1356_nuvei_partial_approval branch October 18, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants