Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ebanx: Add network token support #5263

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

Buitragox
Copy link
Collaborator

Summary:

Add network token support to ebanx gateway.

Remote Test:

The test "test_successful_purchase_passing_processing_type_in_header" fails because of an invalid integration key.
This test adds a header that routes the request to a different environment where the integration key is not valid.
Documentation about this can be found here.

43 tests, 106 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 97.6744% passed

Unit Tests:

6026 tests, 80391 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

RuboCop:

801 files inspected, no offenses detected

@@ -187,7 +195,8 @@ def test_partial_refund
def test_failed_refund
response = @gateway.refund(@amount, '')
assert_failure response
assert_match('Parameter hash not informed', response.message)
assert_equal 'Parameters hash or merchant_payment_code not informed', response.message
assert_equal 'BP-REF-1', response.error_code
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error description for error BP-REF-1 changed. The docs appear to be outdated.

response = @gateway.purchase(@amount, @network_token, @options)
assert_failure response
assert_equal 'Field network_token_expire_date is invalid', response.message
assert_equal 'BP-DR-136', response.error_code
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error codes for network tokens are not present in the docs.

@almalee24 almalee24 requested a review from a team September 13, 2024 20:24
Copy link
Collaborator

@jherreraa jherreraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

Summary:
------------------------------
Add network token support to ebanx gateway.

Remote Test:
------------------------------
The test "test_successful_purchase_passing_processing_type_in_header" fails because of an invalid integration key.
This test adds a header that routes the request to a different environment where the integration key is not valid.
Documentation about this can be found [here](https://developer.ebanx.com/docs/integration/guides/integration-guide#header).

43 tests, 106 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
97.6744% passed

Unit Tests:
------------------------------
6026 tests, 80391 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

RuboCop:
------------------------------
801 files inspected, no offenses detected
@Buitragox Buitragox merged commit 60145d9 into master Nov 7, 2024
0 of 5 checks passed
@Buitragox Buitragox deleted the OPPS-29_ebanx_network_tokens branch November 7, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants