Worldpay: Support apple pay recurring #5268
Open
+68
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KenderBolivarT
force-pushed
the
COMP-71_add_apple_pay_to_world_pay
branch
from
47b6230
to
d0d3311
Compare
aenand
reviewed
Sep 19, 2024
aenand
requested changes
Sep 19, 2024
| response = stub_comms do | ||
| @gateway.authorize(@amount, @apple_pay_network_token_without_payment_cryptogram, @options) | ||
| end.check_request do |_endpoint, data, _headers| | ||
| assert_match %r(<EMVCO_TOKEN-SSL type="APPLEPAY">), data |
There was a problem hiding this comment.
Can we also add a check to ensure the cryptogram is not sent? Maybe something like this:
Suggested change
| assert_match %r(<EMVCO_TOKEN-SSL type="APPLEPAY">), data | |
| refute_match %r(<cryptogram>), data |
COMP-73 Adds support for Apple Pay MIT recurring Test Summary Local: Unit: 125 tests, 702 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 111 tests, 479 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 98.1982% passed
KenderBolivarT
force-pushed
the
COMP-71_add_apple_pay_to_world_pay
branch
from
d0d3311
to
bb2a7b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMP-73
Adds support for Apple Pay MIT recurring
Unit:
125 tests, 702 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Remote:
111 tests, 479 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
98.1982% passed