Updates gemspec to use pessimistic versioning on dependencies #815
Conversation
|
ci is erroring out, any ideas what's up? |
|
Yeah, I messed up the commit. Working on it now. |
* master: gemspec: Dont force nokogiri lesser than 1.6.0 Eway: Update supported countries Fixed a bug in the handling of multiple charges to the same customer Conflicts: activemerchant.gemspec
|
Version locking to active_support 3.2 is going to make it impossible for any developers using rails 4.0 to use this gem. We shouldn't be using anything in active_support hard requires |
|
Looks like active_support is constrained by the various |
|
Never mind, I answered my own question. |
…tivesupport version
* master: Allow nokogiri as low as 1.4.7 Balanced: Adjust BalancedGateway::Error parent SecureNet: Allow some optional fields WebPay: add tests to modify currency unit in JPY from yen to sen. WebPay: modify refund method to support the new currency unit in JPY. WebPay: add unit tests to check the currency unit. WebPay: update a test API key. WebPay: modify the currency unit in JPY from yen (1) to sen (1/100). Update Stripe gateway to reflect current currency support added missing authorization_code param to response Moneris: Add verification_value support Credit deprecation test for litle. Litle: Deprecate credit method in favor of refund. Pass the primary response into the run method instead of tacking it on the end. Stripe: Make the actual refund response primary rather than the fee refund. Allow changing the primary response of a MultiResponse to the first one run. Firstdata E4: Include missing address information for AVS and CVV results. Conflicts: activemerchant.gemspec
|
@jduff @csaunders Everything is passing now. I had to make some concessions to support all the rails versions we target in Travis, but all the runtime requirements now have an intelligent lower and upper version boundary so there shouldn't be any surprises when the next major version of a gem we depend on comes out. |
|
Fabulous! |
Updates gemspec to use pessimistic versioning on dependencies
Partially reverts f09138e References activemerchant#813, activemerchant#765, activemerchant#815
|
@jhawthorn This patch doesn't force old versions of Nokogiri (or the other libs, as far as I'm aware). It's designed to protect users against major version changes (e.g. 2.x.x to 3.x.x) in dependencies that will break AM by proxy. In the Nokogiri example specifically, the gemspec says this: |
Let's talk about versioning.
The majority of ruby gems use (and the rest should use) the Rational Versioning Policy defined by RubyGems.org.
Currently,
active_merchanthas several sub-optimal version definitions on its dependencies. Things likeand
Since patch and minor version changes should not break backwards compatibility, let's ditch these and instead start using pessimistic versioning in all applicable cases. The above examples become
Much cleaner.
I've updated the gemspec to use pessimistic versioning for all of the runtime dependencies. I've left the development dependencies alone for now as I'm not sure how best to proceed there.