Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logos #1154

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add logos #1154

wants to merge 7 commits into from

Conversation

vponline
Copy link
Contributor

Why are you adding this icons?

I'm adding/updating this icon(s) because ..

Help us identify yourself

  • I'm working/collaborating with the brand directly and they have provided the icons.

Link to the brand guidelines: Volt Design Guidelines

Checklist to add new icons

  • All icons have a corresponding entry in db/payment_icons.yml
  • I have followed the icon guidelines detailed in the CONTRIBUTING.md file
  • I have optimized the icon with SVGO
  • I am confident that all icons are clear and easy to read/understand
  • I have provided a link to the brand icon’s brand guidelines whenever possible.
  • I have attached a screenshot comparison with the example icon provided in guidelines
  • I recognize that if my icon is not approved by the Shopify Partners team it may not receive review nor merger.

Attach a screenshot of the icon along side the example Visa icon

image_720

@hellicarusprime
Copy link
Collaborator

Hi @vponline there is already an HSBC logo available so you don't need to add another one. Please update and I'll review.

@hellicarusprime
Copy link
Collaborator

@vponline I noticed that the icons you want to add are missing a visible border. Please refer to this section of our contributing guidelines.

@vponline
Copy link
Contributor Author

@hellicarusprime fixes have been applied, please check again 🙏

Copy link
Contributor

@Lovedanihonjin Lovedanihonjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revise the SVG files:

You are using an incorrect border radius. The border must have a 2px radius (outside stroke)
Screenshot 2024-05-16 at 10 37 12 AM

@vponline
Copy link
Contributor Author

Are there any further changes required to get these accepted please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants