Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add favepay to payment_icons #1158

Merged
merged 4 commits into from
Apr 3, 2024

Conversation

chongzheng1995
Copy link
Contributor

@chongzheng1995 chongzheng1995 commented Apr 2, 2024

Why are you adding this icons?

I'm adding/updating this icon(s) because ..

Help us identify yourself

  • I'm associated with the brand and I've read all the brand icon’s guidelines.

Link to the brand guidelines:

Checklist to add new icons

  • All icons have a corresponding entry in db/payment_icons.yml
  • I have followed the icon guidelines detailed in the CONTRIBUTING.md file
  • I have optimized the icon with SVGO
  • I am confident that all icons are clear and easy to read/understand
  • I have provided a link to the brand icon’s brand guidelines whenever possible.
  • I have attached a screenshot comparison with the example icon provided in guidelines
  • I recognize that if my icon is not approved by the Shopify Partners team it may not receive review nor merger.

If this pull request is not adding new icons, you can remove this checklist.

Attach a screenshot of the icon along side the example Visa icon

image

@chongzheng1995 chongzheng1995 marked this pull request as ready for review April 2, 2024 08:05
@hellicarusprime hellicarusprime self-requested a review April 2, 2024 12:39
@dannye0231 dannye0231 merged commit 15e1410 into activemerchant:master Apr 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants