Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search_form_for does no longer work with arrays #494

Closed
daniel-rikowski opened this issue Jan 14, 2015 · 3 comments
Closed

search_form_for does no longer work with arrays #494

daniel-rikowski opened this issue Jan 14, 2015 · 3 comments

Comments

@daniel-rikowski
Copy link

Previously it was possible to use search_form_for with an array parameter, just like form_for

e.g.

search_form_for [:admin, @q] do |f|

In Ransack 1.6.x this no longer works. It look like c6c163c has removed some brackets which were in fact necessary to ensure the correct code execution order.

@jonatack
Copy link
Contributor

Thank you. Will re-add the parentheses right away. The test suite never raised this issue, so we'll need to add tests for this.

jonatack added a commit that referenced this issue Jan 14, 2015
Follow-up to previous commit 83ce93b to address issue #494.
@jonatack
Copy link
Contributor

Regression test added.

@daniel-rikowski
Copy link
Author

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants