Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop older Ruby and Rails support #857

Closed
scarroll32 opened this issue Dec 29, 2017 · 5 comments
Closed

Drop older Ruby and Rails support #857

scarroll32 opened this issue Dec 29, 2017 · 5 comments
Assignees

Comments

@scarroll32
Copy link
Member

scarroll32 commented Dec 29, 2017

Bring Ransack into line with Polyamorous and drop some older versions.

https://github.com/activerecord-hackery/polyamorous/blob/master/.travis.yml

Posted here in case before proceeding in case this breaks other code, eg ActiveAdmin activeadmin/activeadmin#5254 cc @varyonic

@seanlinsley
Copy link
Contributor

I'm always a fan of reducing the complexity of libraries by only supporting the latest major versions of co-dependencies; it's not worth the extra burden it puts on maintainers. If people on old Rails versions want a new feature, they can patch it into their own fork or convince a maintainer to backport it.

Though I would recommend an X or Y version bump (of X.Y.Z) so that it's easy to release bug fixes to older versions if necessary.

@varyonic
Copy link
Contributor

varyonic commented Jan 3, 2018

Ruby 2.2 is EOL end of this March, 2018.
Rails 4.2 will receive severe security fixes until 6.0 is available.
It would be nice to match these dates for library maintenance, but not required if it is indeed a burden.

@avit
Copy link
Contributor

avit commented Jan 3, 2018

+1 on this to simplify everything. I had suggested moving the multiple version support around in #416 but never got back around to working on it.

I think it could be structured it so the current supported version is the explicit one, but there can still be some facility to include backports as separate modules if anyone wants to contribute them.

Personally I still depend on ransack with a Rails 3.2 application (I know, ouch), but can't expect the community to continue supporting that!

@scarroll32
Copy link
Member Author

@varyonic that makes sense.

@scarroll32
Copy link
Member Author

scarroll32 commented Feb 6, 2018

So do we go forward with the below?

Rails

5.1, 5.0 and 4.2

As per this page

Ruby

2.2 until end of March 2018
2.3
2.4

As per this page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants