-
-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop older Ruby and Rails support #857
Comments
I'm always a fan of reducing the complexity of libraries by only supporting the latest major versions of co-dependencies; it's not worth the extra burden it puts on maintainers. If people on old Rails versions want a new feature, they can patch it into their own fork or convince a maintainer to backport it. Though I would recommend an X or Y version bump (of X.Y.Z) so that it's easy to release bug fixes to older versions if necessary. |
Ruby 2.2 is EOL end of this March, 2018. |
+1 on this to simplify everything. I had suggested moving the multiple version support around in #416 but never got back around to working on it. I think it could be structured it so the current supported version is the explicit one, but there can still be some facility to include backports as separate modules if anyone wants to contribute them. Personally I still depend on ransack with a Rails 3.2 application (I know, ouch), but can't expect the community to continue supporting that! |
@varyonic that makes sense. |
Bring Ransack into line with Polyamorous and drop some older versions.
https://github.com/activerecord-hackery/polyamorous/blob/master/.travis.yml
Posted here in case before proceeding in case this breaks other code, eg ActiveAdmin activeadmin/activeadmin#5254 cc @varyonic
The text was updated successfully, but these errors were encountered: