Bump Polyamorous to 1.3.2 for Rails 5.2 support #858
Conversation
| @@ -6,8 +6,8 @@ Gem::Specification.new do |s| | |||
| s.name = "ransack" | |||
| s.version = Ransack::VERSION | |||
| s.platform = Gem::Platform::RUBY | |||
| s.authors = ["Ernie Miller", "Ryan Bigg", "Jon Atack"] | |||
| s.email = ["ernie@erniemiller.org", "radarlistener@gmail.com", "jonnyatack@gmail.com"] | |||
There was a problem hiding this comment.
My understanding of authors is that it represents the people who wrote a substantial portion of the library. I could certainly be wrong, though.
On the other extreme, ActiveAdmin only lists Greg Bell as an author:
There was a problem hiding this comment.
Any chance the code could be tested @seanlinsley ?
There was a problem hiding this comment.
Agreed. Do not change authors. I wonder even if it's required to change anything since ~1.3 means 1.3.2 too
There was a problem hiding this comment.
Unless there's a reason to prevent applications from using 1.3.0 and 1.3.1, @bbonislawski appears to be right.
There was a problem hiding this comment.
Given there's no "maintainers" section, I'm fine with adding an author, personally.
|
@bbonislawski it was added as 1.3.2 as it wasn't picking up the changes in Polyamorous. Perhaps merge this change with #859 and we can try for a 5.2 - friendly release. I think we should also consider putting Ransack on a bit of a diet, and dropping older Rails support. #857 what do you think? |
|
👍 (I posted my thoughts on #857) |
|
OK to merge this? |
|
Looks good to me |
…/polyamorous_1.3.2 Bump Polyamorous to 1.3.2 for Rails 5.2 support
Please add comments / review before this is merged.