Don't escape period characters with wildcard searches in mysql2 #1013
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ransack is currently escaping period characters in mysql2. This is not correct and makes it impossible to search for things with periods in it (like email addresses). In my limited experience with Postgres I believe it's correct to escape it there -- my patch splits the Postgres vs Mysql2 logic so the escaping for Postgres is left unchanged.
Only % and _ should be escaped since these are the only pattern characters supported in mysql:
https://dev.mysql.com/doc/refman/5.7/en/string-comparison-functions.html