Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only include necessary files in gem package #1104

Conversation

tvdeyen
Copy link
Contributor

@tvdeyen tvdeyen commented Jan 13, 2020

This gem also includes the polyamorous gem (for now). We must not include its code inside the ransacks gem package.

Closes #1102

This gem also includes the polyamorous gem (for now). We must not
include its code inside the ransacks gem package.
@scarroll32 scarroll32 merged commit aee2d97 into activerecord-hackery:master Jan 13, 2020
@scarroll32
Copy link
Member

Thank you @tvdeyen !

@tvdeyen tvdeyen deleted the 1102-remove-polyamorous-from-ransack-package branch January 13, 2020 17:23
@tvdeyen
Copy link
Contributor Author

tvdeyen commented Jan 13, 2020

@seanfcarroll any change to release this on rubygems? The current releases have the duplicated code in them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Packaged gem includes polyamorous code twice
2 participants