Add Rails 6.1 support #1172
Merged
Add Rails 6.1 support #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, this is incredible @deivid-rodriguez !!! Thank you from the whole Ransack community! |
|
No problem, hopefully it works fine. Still need to get tests passing again on older Rails but shouldn't be too hard. |
This method changes a lot in Rails 6.1. If we can rely on Rails version, everything is easier.
deivid-rodriguez
force-pushed
the
rails_6.1_support
branch
from
8033f48 to
39cb1f9
Compare
Also to catch up with rails/rails@10b36e8.
deivid-rodriguez
force-pushed
the
rails_6.1_support
branch
from
39cb1f9 to
2e110e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1127.
Closes #1163.