-
-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable GitHub Actions #1180
Enable GitHub Actions #1180
Conversation
- Use ubuntu-20.04 - Use Ruby 2.7 - CI against SQLite3, MySQL and PostgreSQL databases - CI against Rails v6.1.0.rc1, v6.0.3, 6-0-stable, 5-2-stable and v5.2.4 - Add MYSQL_USERNAME and MYSQL_PASSWORD environment variables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yahonda, this is awesome! 🎉
Could you also replace the Travis badge in the README with Github Actions, and replace any other mentions to TravisCI in the repo?
Also, it's great to verify that ransack works fine with ruby 2.7, but I guess we should keep testing against 2.6.6 just in case. Could add a matrix.ruby dimension and test both?
Finally, and as a little nitpick, could you use an exact version, like 2.7.2. It's a personal preference, and it's what was previously used in the TravisCI configuration, so we should keep it that way.
And, and we should also completely delete the previous travis configuration :) |
Thanks for the review. Sure let me update this pull request as suggested. |
Merging to get a CI back on track! |
Thanks so much @yahonda! |
This pull request enables GitHub Actions to run unit tests.
Refer #1176 (comment) for the background of this pull request.