Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GitHub Actions #1180

Merged
merged 6 commits into from
Dec 1, 2020
Merged

Enable GitHub Actions #1180

merged 6 commits into from
Dec 1, 2020

Conversation

yahonda
Copy link
Contributor

@yahonda yahonda commented Dec 1, 2020

This pull request enables GitHub Actions to run unit tests.

  • Use ubuntu-20.04
  • Use Ruby 2.7
  • CI against SQLite3, MySQL and PostgreSQL databases
  • CI against Rails v6.1.0.rc1, v6.0.3, 6-0-stable, 5-2-stable and v5.2.4
  • Add MYSQL_USERNAME and MYSQL_PASSWORD environment variables

Refer #1176 (comment) for the background of this pull request.

- Use ubuntu-20.04
- Use Ruby 2.7
- CI against SQLite3, MySQL and PostgreSQL databases
- CI against Rails v6.1.0.rc1, v6.0.3, 6-0-stable, 5-2-stable and v5.2.4
- Add MYSQL_USERNAME and MYSQL_PASSWORD environment variables
Copy link
Contributor

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yahonda, this is awesome! 🎉

Could you also replace the Travis badge in the README with Github Actions, and replace any other mentions to TravisCI in the repo?

Also, it's great to verify that ransack works fine with ruby 2.7, but I guess we should keep testing against 2.6.6 just in case. Could add a matrix.ruby dimension and test both?

Finally, and as a little nitpick, could you use an exact version, like 2.7.2. It's a personal preference, and it's what was previously used in the TravisCI configuration, so we should keep it that way.

@deivid-rodriguez
Copy link
Contributor

And, and we should also completely delete the previous travis configuration :)

@yahonda
Copy link
Contributor Author

yahonda commented Dec 1, 2020

Thanks for the review. Sure let me update this pull request as suggested.

@deivid-rodriguez
Copy link
Contributor

Merging to get a CI back on track!

@deivid-rodriguez deivid-rodriguez merged commit 6bb534d into activerecord-hackery:master Dec 1, 2020
@deivid-rodriguez
Copy link
Contributor

Thanks so much @yahonda!

@yahonda yahonda deleted the run_ci_github_actions branch December 1, 2020 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants