CI against Ruby 3.0.0 #1190
Merged
CI against Ruby 3.0.0 #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails 6.0.3 or higher is required to support Ruby 3 keyword arguments behavior. * Rails 6.0.3 has been released! https://weblog.rubyonrails.org/2020/5/6/Rails-6-0-3-has-been-released/ > This version fixes warnings when used with Ruby 2.7. * Ruby 3.0.0 Released https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/ > Keyword arguments are separated from other arguments.
deivid-rodriguez
approved these changes
Dec 27, 2020
|
Thanks for the review. In my opinion, Dropping Rails 5.2 support is still needed now. |
|
@yahonda Do you mean that "Rails 5.2 is still needed" or that "dropping Rails 5.2 support is still needed"? Couldn't understand if you're in favor or against the change 😅. |
|
Thanks for the confirmation. I meant to say "Rails 5.2 is still needed" . |
|
Ok, I don't have a special interest in dropping 5.2 support right now so let's leave it for now. |
|
Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request runs CI against Ruby 3.0.0.
Rails 6.0.3 or higher is required to support Ruby 3 keyword arguments behavior then excluded the matrix between Ruby 3.0.0 and Rails 5.2.x.
https://weblog.rubyonrails.org/2020/5/6/Rails-6-0-3-has-been-released/
https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/